nixos76: shellcheck quick-switch

quick-switch.sh

@@ -6,16 +6,20 @@ commitchanges="false"
 while getopts 'c' OPTION; do
   case "$OPTION" in
   c) commitchanges="true" ;;
+  *) exit 1 ;;
   esac
 done
 
 # Stolen from https://stackoverflow.com/a/29436423
 function yes_or_no {
   while true; do
-        read -p "$* [y/n]: " yn
+    read -r -p "$* [y/n]: " yn
     case $yn in
     [Yy]*) return 0 ;;
-            [Nn]*) echo "Aborted" ; return  1 ;;
+    [Nn]*)
+      echo "Aborted"
+      return 1
+      ;;
     esac
   done
 }
@@ -38,18 +42,16 @@ function apply() {
 }
 
 function commit_and_apply() {
-  read -p "Git working directory is unclean. Commit message: " msg
+  read -r -p "Git working directory is unclean. Commit message: " msg
   git add .
   git commit -m "$(hostname): $msg"
   apply
 }
 
-if [ -z "$(git status --porcelain)" ]
-then
+if [ -z "$(git status --porcelain)" ]; then
   apply
 else
-  if [ "$commitchanges" == "false" ]
-    then
+  if [ "$commitchanges" == "false" ]; then
     echo "Using local flake..."
     sudo nixos-rebuild switch --show-trace --flake .
     reset_bspwm
@@ -57,6 +59,6 @@ else
     echo "Committing flake and pushing..."
     commit_and_apply
   fi
+  # shellcheck disable=SC2028
   echo "\nOperation completed."
 fi
-